Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to avoid the layer index to get unusable in case of tx rollback #60

Closed
wants to merge 4 commits into from

Conversation

amorgner
Copy link
Contributor

This PR will disable the caching of the previously added geometry node.

Background: If the transaction in which a geometry node is added to the db is rolled back, previousGeomNode will never be reset, making the whole index unusable because of a NotFoundException being thrown by

previousGeomNode.createRelationshipTo(geomNode, SpatialRelationshipTypes.NEXT_GEOM);

There might be better solutions, but maybe this is something to start from.

@amorgner
Copy link
Contributor Author

@peterneubauer
Copy link
Contributor

@amorgner , could you update and squash this PR so I can merge it into the current code? Happy New Year!

@amorgner
Copy link
Contributor Author

amorgner commented Jan 3, 2013

Happy New Year to you, too!

Trying to get current spatial version running again .. seems the changes 2 months ago broke things for us here ..

@peterneubauer
Copy link
Contributor

Can you get a clean build to work, with a clean build of graph-collections?

On Thu, Jan 3, 2013 at 12:08 PM, amorgner notifications@github.com wrote:

Happy New Year to you, too!

Trying to get current spatial version running again .. seems the changes 2
months ago broke things for us here ..


Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-11840502.

@amorgner
Copy link
Contributor Author

amorgner commented Jan 3, 2013

Ah, sorry, I meant the spatial search in structr doesn't work with the current spatial version.

neo4j-spatial builds fine with the current graph-collections (using 1.8.1) and doesn't show the NoSuchMethodError (as reported here: https://groups.google.com/forum/?fromgroups=#!topic/neo4j/akcZ9poS1ik)

As soon as I got this to work again, I'll have a look into this issue.

@amorgner
Copy link
Contributor Author

amorgner commented Jan 3, 2013

After upgrading to current 0.10-SNAPSHOT I cannot reproduce the NotFoundException in any way. Closing it.

@ehx-v1
Copy link
Contributor

ehx-v1 commented May 9, 2016

it would be better anyway to have previousGeomNode reset by a TransactionEventHandler reacting upon rollback

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants