Extract NeoDash auth module to an abstract interface to allow for different providers #767
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #767 +/- ##
===========================================
- Coverage 37.49% 37.36% -0.14%
===========================================
Files 216 220 +4
Lines 9140 9274 +134
Branches 2703 2730 +27
===========================================
+ Hits 3427 3465 +38
- Misses 5654 5745 +91
- Partials 59 64 +5 ☔ View full report in Codecov by Sentry. |
|
nielsdejong
changed the title
| throw new Error(`Not Implemented: ${functionName}`); | ||
| }; | ||
|
|
||
| export abstract class ConnectionModule { |
There was a problem hiding this comment.
Add some docstrings here, since it's a pretty important interface we should document it well
| throw new Error(`Not Implemented: ${functionName}`); | ||
| }; | ||
|
|
||
| export abstract class NeodashRecordParser { |
There was a problem hiding this comment.
this will break right? bulkParse for tables?
Maybe we can just leave out the record parser in this iteration of the code.
There was a problem hiding this comment.
from testing didn't looked like it was breaking, but we can just remove it to be 100% sure.
| } | ||
|
|
||
| loadDashboard(_id: string): any { | ||
| return notImplementedError('loadDashboard'); |
There was a problem hiding this comment.
are we including dashboards CRUD operations in the current scope or not yet?
There was a problem hiding this comment.
Ideally we should, but let's focus first on migrating the format of the records, i think that's more urgent. In the current release we should just create the base for the next releases.
| @@ -303,70 +303,71 @@ export const loadDashboardFromNeo4jThunk = (driver, database, uuid, callback) => | |||
|
|
|||
| try { | |||
| const query = 'MATCH (n:_Neodash_Dashboard) WHERE n.uuid = $uuid RETURN n.content as dashboard'; | |||
There was a problem hiding this comment.
We should manually check that all these operations (dashboard load via share link, dashboard load via sidebar, dashboard load in readonly mode) are all still functional. There's quite some breaking points that we should double check before pushing out the next release.
src/report/Report.tsx
Outdated
|
|
||
| const setRecords = (records) => { | ||
| let toSet = records; | ||
| if (['table'].includes(type)) { |
There was a problem hiding this comment.
Remove this since it's not finished?
Add a todo for later?
There was a problem hiding this comment.
Yeah we can do it, but from next release we must start the migration to the new abstracted model
|
Detaching the query and authentication logic to a new class