Merge NeoDash Hive fork with NeoDash 2.4.4 - Extract Auth Module #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/hive
…into feature/hive
… is owned. Removed flashing of screens at the start of app launch
nielsdejong
changed the title
nielsdejong
commented
Mar 19, 2024
| @@ -24,61 +24,61 @@ | |||
| // -- This will overwrite an existing command -- | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
| Cypress.Commands.add('getDataTest', (dataTestSelector) => { | |||
There was a problem hiding this comment.
@alfredorubin96 why is the Cypress stuff updated as part of this PR?
Does this come from something else?
There was a problem hiding this comment.
i don't know why but it's mostly formatting
nielsdejong
commented
Apr 3, 2024
…loneDatabase; removed comments
alfredorubin96
approved these changes
Apr 8, 2024
| @@ -24,61 +24,61 @@ | |||
| // -- This will overwrite an existing command -- | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
| Cypress.Commands.add('getDataTest', (dataTestSelector) => { | |||
There was a problem hiding this comment.
i don't know why but it's mostly formatting
public/config.json
Outdated
| @@ -16,5 +16,19 @@ | |||
| "standaloneDatabaseList": "neo4j", | |||
| "loggingMode": "0", | |||
| "loggingDatabase": "logs", | |||
| "customHeader": "" | |||
| "customHeader": "", | |||
| "connectionModule": "hive", | |||
There was a problem hiding this comment.
i think this should be into connectionConfig.ts instead of having it into public, or at least change the name of the field from extension to connectionModuleConfig or something like that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes NeoDash usable with multiple connection providers (Hive and direct-db)