This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
Fix java version check #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontusmelke
force-pushed
the
support-jdk10
branch
from
4b2c06e
to
d6436c8
Compare
craigtaverner
suggested changes
Sep 6, 2018
pontusmelke
force-pushed
the
support-jdk10
branch
from
d6436c8
to
0c027c0
Compare
|
@craigtaverner indeed a mistake, thanks for catching. Should be fixed now. |
craigtaverner
approved these changes
Sep 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just pulling out the fix for the erroneous version check of #126. We still have some way to go to get full java 10 support.