fix: gotoDefinition workaround for java on Windows #2742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
You are correct. |
|
I'll fix the issues while avoid |
|
bf94769 does not fix the issue. Pulled master, rebuilt, and am still getting the same error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: neoclide/coc-java#82
Adds specific workarounds to fix "go to definition" functionality on Windows.
Two workarounds are implemented:
As the
:editcommand was failing, we instead callnvim_buf_set_nameto set the buffer name without expansion. Then we:editthe current file in order to run autocommands.Additionally, the URI of the loaded definition was
unknown:2, which is incorrect. So we do not normalize the path when in ajdt://file.