fix(language-client): register DiagnosticRefreshRequest #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaegassy/coc-volar#327 1. LSP 3.16 and before, only push mode, server `publishDiagnostics` 2. LSP 3.17 added `refreshSupport`, server will ask client to refresh from `workspace/diagnostic/refresh` 3. LSP 3.17 also added pull mode, server provides `diagnosticProvider`, client pull diagnostics onSave/onChange etc coc.nvim enabled `refreshSupport` but didn't onRequest DiagnosticRefreshRequest, could't handle `workspace/diagnostic/refresh`. Because no `diagnosticProvider`, coc.nvim cancelled registration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
- Coverage 98.57% 98.55% -0.02%
==========================================
Files 273 273
Lines 26077 26077
Branches 5392 5392
==========================================
- Hits 25706 25701 -5
- Misses 218 221 +3
- Partials 153 155 +2 ☔ View full report in Codecov by Sentry. |
fannheyward
added a commit
that referenced
this pull request
Mar 11, 2024
84ce031 chore(doc): move coc-example-config.* to doc 1238cfc chore: typos (#4931) 37bb3c3 chore(docs): add coc-example-config in vim/lua (#4930) 0cf3c4c fix(list): set foldcolumn to 0 since it isn't applicable (#4929) dd4a5fa fix(language-client): register DiagnosticRefreshRequest (#4928) 96d43df feat(outline): add outline.autoHide (#4926) bd303cf feat(language-client): round progress percentage (#4916) 7f8ae84 fix(model): fire onTextChange on TextChangedI (#4875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaegassy/coc-volar#327
publishDiagnosticsrefreshSupport, server will ask client to refresh fromworkspace/diagnostic/refreshdiagnosticProvider, client pull diagnostics onSave/onChange etccoc.nvim enabled
refreshSupportbut didn't onRequest DiagnosticRefreshRequest, could't handleworkspace/diagnostic/refresh. Because nodiagnosticProvider, coc.nvim cancelled registration.