Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inlayHint): hl_mode = 'replace' for neovim #4949

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

kevinhwang91
Copy link
Contributor

Problem: neovim/neovim#24152 The inlays are affected by the other highlight groups.
Solution: use replace value for hl_mode instead of combine.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (1a8244e) to head (2ad01b0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4949   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         273      273           
  Lines       26077    26077           
  Branches     5392     5392           
=======================================
+ Hits        25705    25706    +1     
+ Misses        219      217    -2     
- Partials      153      154    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward
Copy link
Member

fannheyward commented Mar 20, 2024

From :h nvim_buf_set_extmark, the hl_mode's default value is replace, did I misunderstand it?

coc.nvim uses combine as default value

let opts = { 'hl_mode': get(a:opts, 'hl_mode', 'combine') }

@fannheyward fannheyward merged commit 0d66554 into neoclide:master Mar 20, 2024
4 checks passed
@kevinhwang91 kevinhwang91 deleted the inlay-hl-mode-replace branch March 20, 2024 11:05
fannheyward added a commit that referenced this pull request Mar 26, 2024
9190bfe feat(list): add --buffer to list buffer diags (#4958)
fb030d4 fix(defaultAction) fallback to default action on emtpy expression (#4954)
846994b fix(inlayHint): more compact padding highlight group (#4950)
b01ae44 feat(semanticTokens)!: token highlight groups (#4667)
8c85d6f fix(markdown): incorrect list indentation alignment in markdown parser (#4884)
0d66554 fix(inlayHint): hl_mode = 'replace' for neovim (#4949)
1a8244e chore(package): update dependencies (#4948)
4f68722 feat(client): upgrade to marked 7 (#4947)
574c12c feat(package): @types/node@18 (#4946)
d299c66 feat(menu): C-j/k to navigate menu (#4945)
34d3d9d chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#4944)
aead8f4 chore(CI): use Node 20 (#4940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants