fix(inlayHint): more compact padding highlight group #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the chunk is an array with a single string, the highlight group only uses the foreground of `Normal`, which makes `cursorline` look better.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4950 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 273 273
Lines 26060 26060
Branches 5386 5386
=======================================
Hits 25686 25686
Misses 220 220
Partials 154 154 ☔ View full report in Codecov by Sentry. |
fannheyward
added a commit
that referenced
this pull request
Mar 26, 2024
9190bfe feat(list): add --buffer to list buffer diags (#4958) fb030d4 fix(defaultAction) fallback to default action on emtpy expression (#4954) 846994b fix(inlayHint): more compact padding highlight group (#4950) b01ae44 feat(semanticTokens)!: token highlight groups (#4667) 8c85d6f fix(markdown): incorrect list indentation alignment in markdown parser (#4884) 0d66554 fix(inlayHint): hl_mode = 'replace' for neovim (#4949) 1a8244e chore(package): update dependencies (#4948) 4f68722 feat(client): upgrade to marked 7 (#4947) 574c12c feat(package): @types/node@18 (#4946) d299c66 feat(menu): C-j/k to navigate menu (#4945) 34d3d9d chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#4944) aead8f4 chore(CI): use Node 20 (#4940)
|
inlayhint in vim9 not work from this commit |
Reproduced |
fannheyward
added a commit
that referenced
this pull request
Mar 28, 2024
related #4950 Set hl group for hint in Vim
fannheyward
added a commit
that referenced
this pull request
Mar 28, 2024
related #4950 Set hl group for hint in Vim
|
@qiqiboy made a quick fix, set hl_group for hint in Vim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the chunk is an array with a single string, the highlight group only uses the foreground of
Normal, which makescursorlinelook better.Reference: https://github.com/neovim/neovim/blob/0f85aeb478a68c18a8195e69724e1cb618fec058/runtime/lua/vim/lsp/inlay_hint.lua#L333-L337