Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods screen 'Illegal format found' #734

Closed
ApexModder opened this issue Mar 21, 2024 · 1 comment
Closed

Mods screen 'Illegal format found' #734

ApexModder opened this issue Mar 21, 2024 · 1 comment
Labels
triage Needs triaging and confirmation

Comments

@ApexModder
Copy link
Contributor

ApexModder commented Mar 21, 2024

Minecraft Version: 20.4/5

NeoForge Version: 20.4.184 / 20.5.0-alpha.24w12a [local build]

Steps to Reproduce:

  1. Set mod name to something with a ' (Fantasy's Dice)
  2. Launch game and open the mods screen
  3. Console will spam something like the following
    [18:36:30] [Render thread/ERROR] [ne.ne.ne.co.I18nExtension/CORE]: Illegal format found Fantasy's Dice

Description of issue:
When including a ' in your mods name for possessiveness it causes a illegal format issue when opening the mods screen, and possibly anywhere else which references the mods name.

Break points seem to show that the game is thinking its a unterminated string, but shouldn't it be looking for " for string terminations? I am using ' for possessiveness in my mods name.

Extended conversation in Neo-cord

Break point of error/exception

image

@ApexModder ApexModder added the triage Needs triaging and confirmation label Mar 21, 2024
@embeddedt
Copy link
Member

This was fixed by #851 for 1.20.5 and #686 for 1.20.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

2 participants