-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layer file download: final rename: fix durability #6991
Merged
problame
merged 4 commits into
main
from
problame/integrate-tokio-epoll-uring/write-path/ondemand-download-preliminary-1
Mar 5, 2024
Merged
layer file download: final rename: fix durability #6991
problame
merged 4 commits into
main
from
problame/integrate-tokio-epoll-uring/write-path/ondemand-download-preliminary-1
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, the layer file download code would fsync the inode after rename instead of the timeline directory. That is not in line with what a comment further up says we're doing, and it's obviously not achieving the goal of making the rename durable. part of #6663
…kio-epoll-uring/write-path/ondemand-download-preliminary-1
problame
commented
Mar 1, 2024
koivunej
reviewed
Mar 1, 2024
koivunej
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of fsync(new)
after rename or the discrepency due to lack of it to the comment above, this is already a good fix. Good note on the sync_all blocking on std-fs, bifurcation.
2484 tests run: 2362 passed, 0 failed, 122 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
cc22d64 at 2024-03-05T11:15:22.517Z :recycle: |
koivunej
approved these changes
Mar 5, 2024
…kio-epoll-uring/write-path/ondemand-download-preliminary-1
problame
deleted the
problame/integrate-tokio-epoll-uring/write-path/ondemand-download-preliminary-1
branch
March 5, 2024 11:09
problame
added a commit
that referenced
this pull request
Mar 5, 2024
problame
added a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the layer file download code would fsync the inode after
rename instead of the timeline directory. That is not in line with what
a comment further up says we're doing, and it's obviously not achieving
the goal of making the rename durable.
part of #6663