Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup(#6991): it broke the macOS build #7024

Merged
merged 1 commit into from Mar 5, 2024
Merged

fixup(#6991): it broke the macOS build #7024

merged 1 commit into from Mar 5, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Mar 5, 2024

No description provided.

@problame problame requested a review from a team as a code owner March 5, 2024 14:23
@problame problame requested a review from jcsp March 5, 2024 14:23
@problame problame enabled auto-merge (squash) March 5, 2024 14:43
bayandin
bayandin approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works locally

@bayandin bayandin added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

2490 tests run: 2366 passed, 0 failed, 124 skipped (full report)

Code coverage* (full report)

  • functions: 28.8% (6982 of 24241 functions)
  • lines: 47.4% (42876 of 90517 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
87c0ff0 at 2024-03-05T15:31:31.014Z :recycle:

@problame problame merged commit eacdc17 into main Mar 5, 2024
56 checks passed
@problame problame deleted the problame/fixup-6991-macos-build branch March 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayandin bayandin bayandin approved these changes

@jcsp jcsp jcsp approved these changes

Assignees
No one assigned
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@problame @bayandin @jcsp