TASK: Remove deprecated asset argument usage
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhard-boden
force-pushed
the
deprecate-asset-argument
branch
from
d1c25c8
to
798a38a
Compare
bwaidelich
approved these changes
Jan 16, 2017
kdambekalns
reviewed
Jan 16, 2017
| <f:if condition="{node.properties.chapterImage}"> | ||
| <media:image asset="{node.properties.chapterImage}" class="pull-right" alt="{node.properties.chapterImage.alternativeText}" title="{node.properties.chapterImage.title}" /> | ||
| </f:if> | ||
| <media:image image="{node.properties.chapterImage}" class="pull-right" alt="{node.properties.chapterImage.alternativeText}" title="{node.properties.chapterImage.title}" /> |
There was a problem hiding this comment.
Why is the condition removed here (but not in ChapterMenu.html)?
There was a problem hiding this comment.
In ChapterMenu.html and CarouselItem.html there is an else part, too so it would change behavior
There was a problem hiding this comment.
@kdambekalns We don't need the condition anymore, since the Image ViewHelpers now behaves correctly and gracefully falls back to empty string, if no image is present:
neos/neos-development-collection#1203
and about the other files: what @bwaidelich said
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
assetwithimagewithin various templates.see: neos/neos-development-collection#1371