Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render id={form.identifier} around ConfirmationFinisher #129

Closed
wants to merge 1 commit into from
Closed

Render id={form.identifier} around ConfirmationFinisher #129

wants to merge 1 commit into from

Commits on Jan 5, 2021

  1. Render id={form.identifier} around ConfirmationFinisher 

    The `<form>` is rendered always with`id={form.identifier}`
After submitting the Form `#{form.identifier}` will be added to the URL. 
If the Form is somewhere on the Page, the anchor `#{form.identifier}` will jump to the Form. 

The `Neos.Form.Builder:ConfirmationFinisher` does NOT render `id={form.identifier}` around. 
Because of the missing id, the Browser doesn't jump to the Confirmation Message and it maybe get lost somewhere on the page. 

What about wrapping an `id={form.identifier}` around the Builder:ConfirmationFinisher?
    @paavo
    paavo committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    daa4c95 View commit details
    Browse the repository at this point in the history