Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: 3371 shortcut translations #3937

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

mhsdesign
Copy link
Member

closes: #3371

1

the dutch translation f.x. doesnt have correctly formatted <br/> tags. See f.x.: 'shortcut.clickToContinueToParentNode' and compare the spanish &lt; br / &gt; to the english source &lt;br /&gt;. A search for &lt; br / &gt; reveals multiple cases. The problem is, that this invalid html (due to the space) and will be rendered as text (< br / >).

before in NL:
image

after:
image

2

this translation id doesnt exist: 'shortcut.toSpecificTarget' so the value / fallback This is a shortcut to a specific target: is always used.

It has been missed in 2014 (since Neos 2) ^^ 02f8ff9#diff-d1bec08a4f5050d463e4f7af3d61b767974d858d3d56ced85581ca55c27126dcR6

before in DE (or any other language):
image

after:
nothing to see here yet - but now we can translate via weblate :D

Upgrade instructions

Review instructions

Check the shortcode rendering in the backend.
If you switch your user language - flush the fusion cache - as this is not calculated into the shortcut cache:
./flow cache:flushone Neos_Fusion_Content

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@crydotsnake crydotsnake changed the title Bugfix 3371 shortcut translations BUGFIX: 3371 shortcut translations Oct 27, 2022
Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, and works as expected.

@crydotsnake crydotsnake merged commit 704dcbc into neos:7.3 Oct 27, 2022
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Nov 2, 2022
with neos#3937 we dont need the fallbacks anymore ;)
neos-bot pushed a commit to neos/neos that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants