Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected rebase error in Neos Ui must fail CI #3811

Open
mhsdesign opened this issue Jun 23, 2024 · 0 comments
Open

Unexpected rebase error in Neos Ui must fail CI #3811

mhsdesign opened this issue Jun 23, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

Currently the CI just accepts that a discard was not possible and continues.

image

Discarding happens at the start of every tests (where the success should be asserted)

And this behaviour can even generate a false positive in the case of

FIX #3184: Discarded node move changes are reflected correctly in the document tree
 ✓ Scenario #2: Moved nodes do not just disappear after discarding the move change

as we try to discard - which failed in my case while debugging - and then (no surprise) the nodes of course still exist in the tree, but we didnt assert the correct position but just that they can be found somewhere.

...

For error flashmessages we handle it the way that we assert that no console errors should be logged... maybe we should do the same and just write to the console? Or assert that the dialog looks like a success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant