Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase page very big ~13mb #122

Closed
Sebobo opened this issue Nov 24, 2016 · 7 comments
Closed

Showcase page very big ~13mb #122

Sebobo opened this issue Nov 24, 2016 · 7 comments
Assignees

Comments

@Sebobo
Copy link
Member

Sebobo commented Nov 24, 2016

We should introduce lazy loading here.

I can take care of it.

@Sebobo Sebobo self-assigned this Nov 24, 2016
@kdambekalns
Copy link
Member

kdambekalns commented Nov 24, 2016

This is a dupe of #112, no? Also, see #113

@Sebobo
Copy link
Member Author

Sebobo commented Nov 24, 2016

@kdambekalns Don't think so. It's a bit related but one is about the videos which should maybe not shown on mobile.
These images we want, but only on demand.
I think @bwaidelich can share parts of a codebase for that.

@bwaidelich
Copy link
Member

Can you provide some more details?
https://www.neos.io/features/case-studies.html has ~500kb. Not great but far from 13mb.
The largest seems to be the swisscom case study with ~3.1mb
But this is not due to animated gifs (#112) as far as I can see but mostly due to screenshots that are almost 2mb large(!) (see https://storage.googleapis.com/target.wwwneosio.neos.eu.beach.flownative.net/5796e58c9c104a806af65799d2cc897fd1636d59/Capture%202016-04-06%20at%2015.16.46-1500x742.png for example).

Maybe we should create a general issue for image optimization (size & quality)

@Sebobo Sebobo changed the title Case Study page very big ~13mb Showcase page very big ~13mb Nov 24, 2016
@Sebobo
Copy link
Member Author

Sebobo commented Nov 24, 2016

Sorry I meant the showcase page of course. And it's actually much more.

bildschirmfoto 2016-11-24 um 13 22 56

@bjen
Copy link
Contributor

bjen commented Nov 24, 2016

The show cases are not yet optimized, as I didn't have the time to try to understand how exactly that kind of image rendering works. However starting to optimize images should not only be done for show cases, but in general for this kind of teaser boxes.

@Sebobo
Copy link
Member Author

Sebobo commented Nov 24, 2016

But the image optimization should also be another issue. Here I would like to load what's necessary.
That can be done with a small js plugin and some small adjustments I think.

@bwaidelich
Copy link
Member

Sorry I meant the showcase page of course

Ah, that makes more sense ;)
I think it's two issues:

  1. The image rendering could be optimized: i.e. the thumbnail images are larger (dimension-wise) than they need to be, the compression level can probably also be increased

  2. We currently load 150 showcases at once including images (more relevant in this case)

So +1 for lazy-loading and/or the already planned filter with some decent defaults

Sebobo added a commit to Sebobo/Neos.NeosIo that referenced this issue Nov 24, 2016
This change adds the layzr lazy load library which
loads images when necessary.

Img tags can have the following data-attributes to allow lazyloading:

* data-image-normal (required)
* data-image-retina
* data-image-srcset

The normal src attribute should be set to use a simple loading gif.

Resolves: neos#122
bwaidelich added a commit to bwaidelich/Neos.NeosIo that referenced this issue Nov 24, 2016
This adds a simple filter that allows to restrict show cases by
the *project type* and/or arbitrary search terms.
It also adds support for custom ordering and limits.

Related: neos#122
Sebobo pushed a commit to bwaidelich/Neos.NeosIo that referenced this issue Dec 7, 2016
This adds a simple filter that allows to restrict show cases by
the *project type* and/or arbitrary search terms.
It also adds support for custom ordering and limits.

Related: neos#122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants