fix: Improve nvim detection #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredizzimo
force-pushed
the
fsundvik/fix-nvim-detection
branch
from
f6045c6
to
4bb4450
Compare
fredizzimo
force-pushed
the
fsundvik/fix-nvim-detection
branch
2 times, most recently
from
38f29dd
to
0c0e98a
Compare
Don't rely on the shell specific `exists", instead run `nvim -v`. Additionally, if there's unexpected output, for example if your shell is configured wrongly to output something when run in non-interactive mode, it will tell you so, instead of failing with very strange errors later. The `neovim-bin` argument has also been changed to always require the binary to exist, instead if falling back to `nvim` as that's probably not what the user wants. If `nevoim-bin` contains path separators the binary will be tried directly, otherwise `which` will be used to find the correct executable. The which command has also been changed to always use the which crate first to avoid shell specific issues (for example nushell). The output is printed directly to stderr instead of the log, for a more user friendly experience. Furthermore, the maybe disown call has been moved so that the user actually has a chance to see the errors in the console.
fredizzimo
force-pushed
the
fsundvik/fix-nvim-detection
branch
from
0c0e98a
to
1af661d
Compare
|
This needs testing that it still works though the macOS finder. |
This was referenced Jul 26, 2023
14 tasks
|
LGTM |
rpanachi
approved these changes
Aug 16, 2023
This however also loses possible error messages at startup about the nvim binary not being found.
MultisampledNight
approved these changes
Aug 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Don't rely on the shell specific
exists, instead runnvim -v. Additionally, if there's unexpected output, for example if your shell is configured wrongly to output something when run in non-interactive mode, it will tell you so, instead of failing with very strange errors later.The
neovim-binargument has also been changed to always require the binary to exist, instead if falling back tonvimas that's probably not what the user wants. Ifneovim-bincontains path separators the binary will be tried directly, otherwisewhichwill be used to find the correct executable.The which command has also been changed to always use the which crate first to avoid shell specific issues (for example nushell).
The output is printed directly to stderr instead of the log, for a more user friendly experience. Furthermore, the maybe disown call has been moved so that the user actually has a chance to see the errors in the console.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
neovim-binit does not fallback tonvimautomaticallyFixes #1812
Fixes #1345
Fixes #1229
Fixes #1296
Fixes #1570
Fixes #1945
I think there are more issues, but I can't find any right now.