improve git-related error handling

[justinmk]

(migrated from #12)

When git push fails, currently we keep retrying many times. Should not do that when GH_TOKEN is invalid, and possibly other errors where retrying is just a waste of time.

[acferreir4]

@justinmk Would it suffice to just remove the while/retry loop or should it be replaced with another mechanism for handling an invalid gh_token?

[justinmk]

@acferreir4 Not sure how often requests fail, but if it's more than zero then removing the retry loop will cause failed jobs.

GitHub API doc says it will return 404 in that case. So we only need to break out of the loop if 404 is returned.

Probably this can be done in _check_gh_error. https://github.com/neovim/bot-ci/blob/master/ci/common/github-api.sh

[do-you-dare]

Hello! I'd like to tackle this issue; seems to be a nice start here.

Is the idea breaking from this while if the GH_TOKEN is invalid?

Thanks in advance!

[justinmk]

@dread-uo Thanks for the interest in helping! It looks like here it's already done:

bot-ci/ci/common/common.sh

Line 152 in c5cd104

if ! has_gh_token ; then

This hasn't been a problem in practice, so let's just close this issue.