Update LibUV to 1.7.2.

[fwalch]

neovim/neovim#2604

[ghost]

LGTM

[fwalch]

Ouch...

Assertion failed: (handle->type == UV_TCP || handle->type == UV_TTY || handle->type == UV_NAMED_PIPE), function uv___stream_fd, file /tmp/neovim20150508-1014-157w97p/.deps/build/src/libuv/src/unix/stream.c, line 1528.

[fwalch]

I guess the crucial part of the error is "Vim: Warning: Output is not to a terminal"; how to reproduce such a situation?

[justinmk]

"Vim: Warning: Output is not to a terminal"; how to reproduce such a situation?

That warning appears when Vim is on the left side of a pipe:

echo foo | vim - | cat

I'm building the latest now on OS X to see if I can reproduce the error.

[justinmk]

Is there anybody on OS X that can compile latest master from source and try executing nvim -u NONE +s/Vim/Neovim/g +wq test.txt (with Vim as contents of test.txt)? There might be a problem with LibUV 1.5 (which is used in master, but not yet in Homebrew).

I tried this, and no problems on OS X 10.10.3

[jszakmeister]

I tried this too and had no issues. I also tried redirecting the output and didn't see the error either.

[fwalch]

That's good news, I suppose. But how to fix the build? 😬

[xu-cheng]

This is caused by the lack of tty.

To reproduce it you can either run brew test neovim:

$ brew test neovim
Testing neovim
==> /usr/local/Cellar/neovim/HEAD/bin/nvim -u NONE +s/Vim/Neovim/g +wq test.txt
+wq
test.txt

Vim: Warning: Output is not to a terminal
Assertion failed: (handle->type == UV_TCP || handle->type == UV_TTY || handle->type == UV_NAMED_PIPE), function uv___stream_fd, file /tmp/neovim20150516-37778-1oyjbqk/.deps/build/src/libuv/src/unix/stream.c, line 1528.
Error: neovim: failed
Failed executing: /usr/local/Cellar/neovim/HEAD/bin/nvim -u NONE +s/Vim/Neovim/g +wq test.txt
/usr/local/Library/Homebrew/formula.rb:843:in `block in system'
/usr/local/Library/Homebrew/formula.rb:800:in `open'
/usr/local/Library/Homebrew/formula.rb:800:in `system'
/usr/local/Library/Taps/neovim/homebrew-neovim/Formula/neovim.rb:79:in `block in <class:Neovim>'
/usr/local/Library/Homebrew/formula.rb:743:in `block in run_test'
/usr/local/Library/Homebrew/extend/fileutils.rb:17:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:739:in `run_test'
/usr/local/Library/Homebrew/test.rb:28:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
/usr/local/Library/Homebrew/test.rb:27:in `<main>'

Or below bash command:

$ /bin/bash -c "nvim -u NONE +s/Vim/Neovim/g +wq test.txt" </dev/null  >output.txt 2>&1
[1]    69562 abort      /bin/bash -c "nvim -u NONE +s/Vim/Neovim/g +wq test.txt" < /dev/null >  2>&1

$ cat output.txt
Vim: Warning: Output is not to a terminal
Vim: Warning: Input is not from a terminal
Assertion failed: (handle->type == UV_TCP || handle->type == UV_TTY || handle->type == UV_NAMED_PIPE), function uv___stream_fd, file /tmp/neovim20150516-37778-1oyjbqk/.deps/build/src/libuv/src/unix/stream.c, line 1528.

To work around this, you can use this patch.

diff --git a/Formula/neovim.rb b/Formula/neovim.rb
index 665378a..f3da1f5 100644
--- a/Formula/neovim.rb
+++ b/Formula/neovim.rb
@@ -76,7 +75,7 @@ class Neovim < Formula

   test do
     (testpath/"test.txt").write("Hello World from Vim!!")
-    system bin/"nvim", "-u", "NONE", "+s/Vim/Neovim/g", "+wq", "test.txt"
+    system "script", "-q" ,"/dev/null", bin/"nvim", "-u", "NONE", "+s/Vim/Neovim/g", "+wq", "test.txt"
     assert_equal "Hello World from Neovim!!", File.read("test.txt").strip
   end
 end

FWIW, it would be better that neovim could support environment without tty rather than using the workaround.

[xu-cheng]

Sorry I think I overcomplicate the problem. In fact, it can be reproduced by redirecting stdoutand stderr into the same pipe.

$ nvim -u NONE +s/Vim/Neovim/g +wq test.txt >output.txt 2>&1
[1]    76906 abort      nvim -u NONE +s/Vim/Neovim/g +wq test.txt > output.txt 2>&1

$ cat output.txt
Vim: Warning: Output is not to a terminal
Assertion failed: (handle->type == UV_TCP || handle->type == UV_TTY || handle->type == UV_NAMED_PIPE), function uv___stream_fd, file /tmp/neovim20150516-37778-1oyjbqk/.deps/build/src/libuv/src/unix/stream.c, line 1528.

So it should be considered as a bug.

[fwalch]

Created neovim/neovim#2671, thanks for figuring this out @xu-cheng!

[fwalch]

Okay, finally found a way to avoid the problem by stumbling upon neovim/neovim#3202. Updated to the latest LibUV 1.7.2.

[justinmk]

LGTM

[ghost]

Make sure to send a PR to the main repo too, when you get the chance.