Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): assert that diagnostics have line number and column #16683

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

gpanders
Copy link
Member

Line number and column are required and much of the diagnostic API
assumes that these are both present. When one of the two is missing,
cryptic errors pop up in other parts of the diagnostic subsystem.
Instead, assert that diagnostics are well formed when they are entered
into the cache, which provides a clearer error.

Conflicts with #16675.

Line number and column are required and much of the diagnostic API
assumes that these are both present. When one of the two is missing,
cryptic errors pop up in other parts of the diagnostic subsystem.
Instead, assert that diagnostics are well formed when they are entered
into the cache, which provides a clearer error.
@github-actions github-actions bot added diagnostic lua stdlib and removed lua stdlib labels Dec 16, 2021
@github-actions
Copy link
Contributor

Successfully created backport PR #16687 for release-0.6.

@dundargoc dundargoc removed the request for review from mfussenegger October 29, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants