Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: support InlayHint, a new feature in LSP Spec 3.17 #18086

Closed
oxalica opened this issue Apr 11, 2022 · 6 comments · Fixed by #23984
Closed

LSP: support InlayHint, a new feature in LSP Spec 3.17 #18086

oxalica opened this issue Apr 11, 2022 · 6 comments · Fixed by #23984
Labels
enhancement feature request lsp
Milestone
0.10

Comments

@oxalica
Copy link

oxalica commented Apr 11, 2022 •
edited by justinmk

Feature description

The inlay hint feature is stabilized in latest LSP Spec 3.17, and implemented in VSCode.

The latest stable version of rust-analyzer 2022-04-11 already changed the inlay hint interface from the experimental one to the finalized one. Thus it no longer work with nvim's builtin LSP and lsp_extensions.nvim. Since it's not an experimental feature anymore, I think it's better to be implemented inside nvim rather than plugins.
@oxalica oxalica added the enhancement feature request label Apr 11, 2022
@dundargoc dundargoc added the lsp label Apr 11, 2022
@mjlbach
Copy link
Contributor

mjlbach commented Apr 12, 2022 •
edited

My main motivation for not wanting to do this right now is I'd rather wait for anticonceal to be merged, otherwise we're going to have to hack it with virtual text on the right (how the plugins do it), and it's not really matching the expectation of an inlay hint.

@theoparis theoparis mentioned this issue Apr 17, 2022
Open
@oxalica
Copy link
Author

oxalica commented Apr 17, 2022

I'd rather wait for anticonceal to be merged, otherwise we're going to have to hack it with virtual text on the right (how the plugins do it)

Personally, I'd like to have a toggle option to show all of them at the end of line like the plugins do, despite they are called "inlay hints", since intrusive hints interleave the code and make it hard to read.

@mjlbach
Copy link
Contributor

mjlbach commented Apr 17, 2022

I think it's likely we would implement that by allowing the user to override the function that places the decorations, similar to how we do with the diagnostic API (by registering a handler). I don't think we'll add a config option.

This was referenced Apr 17, 2022
Open
Open
@leaxoy
Copy link
Contributor

leaxoy commented Apr 28, 2022

LSP 3.17 also has another awesome feature, type hierarchy

@jose-elias-alvarez jose-elias-alvarez mentioned this issue May 17, 2022
Closed
@ttys3
Copy link

ttys3 commented Jul 8, 2022

gopls already support inlay hints:

https://github.com/golang/tools/blob/master/gopls/doc/settings.md#inlayhint

https://github.com/golang/tools/blob/master/gopls/doc/inlayHints.md

@polyzen polyzen mentioned this issue Jul 18, 2022
Open
@mfussenegger mfussenegger mentioned this issue Jul 24, 2022
Closed
@oxalica oxalica changed the title [LSP] [Feature] Support InlayHint, a finalized proposal in LSP Spec 3.17 [LSP] [Feature] Support InlayHint, a new stabilized feature in LSP Spec 3.17 Jul 26, 2022
stefanvanburen added a commit to stefanvanburen/dotfiles that referenced this issue Aug 8, 2022
@stefanvanburen
nvim: Add inlay hints to gopls
1801777 
These aren't actually available in core neovim yet[1]. Just adding them
for when the time comes.

[1]: neovim/neovim#18086
@oxalica
Copy link
Author

oxalica commented Aug 15, 2022

Just a note, I found there are plugins implementing inlay hints now, like
https://github.com/lvimuser/lsp-inlayhints.nvim

@jdhao jdhao mentioned this issue Aug 26, 2022
Closed
@glepnir glepnir mentioned this issue Aug 28, 2022
Closed
registerGen added a commit to registerGen/dotfiles that referenced this issue Aug 30, 2022
@registerGen
feat(plugins): add lsp-inlayhints.nvim
cf3955e 
Also waiting for anticonceal (neovim/neovim#9496) and builtin support
(neovim/neovim#18086)
@EdenEast EdenEast mentioned this issue Sep 1, 2022
Merged
@khiet khiet mentioned this issue Nov 11, 2022
Merged
@leisurelicht leisurelicht mentioned this issue Apr 10, 2023
Open
@zeertzjq zeertzjq mentioned this issue May 19, 2023
Closed
@neovim neovim deleted a comment from oblitum May 22, 2023
@TwIStOy TwIStOy mentioned this issue May 23, 2023
Closed
@p00f p00f mentioned this issue May 23, 2023
Merged
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints - implement auto refresh
312bb88 
Implements debounced automatic refresh of inlay hints,
adds public functions in lsp.lua and docs

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints - implement auto refresh
c458aba 
Implements debounced automatic refresh of inlay hints,
adds public functions in lsp.lua and docs

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints - implement auto refresh
269dc15 
Implements debounced automatic refresh of inlay hints,
adds public functions in lsp.lua and docs

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints - implement auto refresh
ebb4197 
Implements debounced automatic refresh of inlay hints,
adds public functions in lsp.lua and docs

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints - implement auto refresh
c525036 
Implements debounced automatic refresh of inlay hints,
adds public functions in lsp.lua and docs

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints
ee28716 
This PR adds auto refresh and a public interface on top of neovim#23736

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints
3cf547d 
This PR adds automatic refresh and a public interface on top of neovim#23736

Closes neovim#18086
@p00f p00f mentioned this issue Jun 11, 2023
Merged
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints
6581372 
This PR adds automatic refresh and a public interface on top of neovim#23736

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 11, 2023
@p00f
feat(lsp): inlay hints
5f3e69f 
This PR adds automatic refresh and a public interface on top of neovim#23736

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 17, 2023
@p00f
feat(lsp): inlay hints
e0f7e86 
This PR adds automatic refresh and a public interface on top of neovim#23736

Closes neovim#18086
p00f added a commit to p00f/neovim that referenced this issue Jun 19, 2023
@p00f
feat(lsp): inlay hints
1e5368c 
This PR adds automatic refresh and a public interface on top of neovim#23736

Closes neovim#18086
@justinmk justinmk changed the title [LSP] [Feature] Support InlayHint, a new stabilized feature in LSP Spec 3.17 LSP: support InlayHint, a new feature in LSP Spec 3.17 Jun 19, 2023
@justinmk justinmk added this to the 0.10 milestone Jun 19, 2023
justinmk pushed a commit that referenced this issue Jun 20, 2023
@p00f
feat(lsp): inlay hints #23984
ca5de93 
Add automatic refresh and a public interface on top of #23736

 * add on_reload, on_detach handlers in `enable()` buf_attach, and
  LspDetach autocommand in case of manual detach
* unify `__buffers` and `hint_cache_by_buf`
* use callback bufnr in `on_lines` callback, bufstate: remove __index override
* move user-facing functions into vim.lsp.buf, unify enable/disable/toggle

Closes #18086
@jaredmcqueen jaredmcqueen mentioned this issue Jun 20, 2023
Closed
@jellydn jellydn mentioned this issue Jun 21, 2023
Closed
@nyngwang nyngwang mentioned this issue Jun 23, 2023
Closed
@loganswartz loganswartz mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request lsp
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

feat(lsp): inlay hints p00f/neovim
6 participants
@justinmk @leaxoy @mjlbach @oxalica @dundargoc @ttys3