Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear highlight doesn't work #4767

Closed
1 task done
edi9999 opened this issue May 16, 2016 · 6 comments
Closed
1 task done

Clear highlight doesn't work #4767

edi9999 opened this issue May 16, 2016 · 6 comments
Labels
bug issues reporting wrong behavior
Milestone

Comments

@edi9999
Copy link

edi9999 commented May 16, 2016

  • Neovim version: NVIM 0.1.5-dev
  • Vim behaves differently Vim version: VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 08 2016 11:38:28) Included patches: 1-1689
  • Operating system/version: Xubuntu
  • Terminal name/version: xfce4-terminal 0.6.3 (Xfce 4.12)
  • $TERM: screen-256color

Actual behaviour

The statements still have syntax highlighting

Expected behaviour

The statements shouldn't have any more syntax highlighting

Steps to reproduce using nvim -u NORC

nvim -u NORC
:e codefile
:syntax on 
:hi Statement term=NONE cterm=NONE ctermfg=NONE ctermbg=NONE gui=NONE guifg=NONE guibg=NONE

See this screenshot: (Left is neovim, right is vim)

selection_040

@edi9999
Copy link
Author

edi9999 commented May 16, 2016

This makes the following colorscheme : https://github.com/robertmeta/nofrils colorful, where its main purpose is to remove most colors

@justinmk
Copy link
Member

justinmk commented May 17, 2016

If you revert d02cfe8 is it fixed?

@AdnoC what do you think?

@edi9999
Copy link
Author

edi9999 commented May 17, 2016

Indeed, reverting the d02cfe8 fixes it

@justinmk justinmk added the bug issues reporting wrong behavior label May 17, 2016
@justinmk justinmk added this to the 0.2 milestone May 17, 2016
@AdnoC
Copy link
Contributor

AdnoC commented May 20, 2016

Huh, I'l take a look at this. I only tested d02cfe8 with hi clear. I didn't think of manually clearing all the fields.

@AdnoC
Copy link
Contributor

AdnoC commented May 20, 2016

I didn't realize I needed to clear the sg_attr field of the highlight group if it was manually cleared. The pull request fixes it.

@edi9999
Copy link
Author

edi9999 commented May 24, 2016

Works indeed, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues reporting wrong behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@justinmk @edi9999 @AdnoC and others