feat(attach): allow custom logger for attach neovim proc #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
requested changes
Jan 8, 2020
rhysd
requested changes
Jan 8, 2020
|
@billyvg Would you also check this PR and make a new release if you're ok? |
billyvg
approved these changes
Jan 8, 2020
|
@kwonoj I merged. Thank you for adding this. |
justinmk
added a commit
that referenced
this pull request
Mar 18, 2024
Problem: d9bc2ef #138 allows clients to supply a custom logger, but the logger is not always used. And the winstonLogger is always initialized, even when a custom logger is given. Solution: - Update all logging calls to use the custom logger. - Skip initialization of winstonLogger if a custom logger is given.
justinmk
added a commit
that referenced
this pull request
Mar 18, 2024
Problem: d9bc2ef #138 allows clients to supply a custom logger, but the logger is not always used. And the winstonLogger is always initialized, even when a custom logger is given. Solution: - Update all logging calls to use the custom logger. - Skip initialization of winstonLogger if a custom logger is given.
justinmk
added a commit
that referenced
this pull request
Mar 18, 2024
Problem: d9bc2ef #138 allows clients to supply a custom logger, but the logger is not always used. And the winstonLogger is always initialized, even when a custom logger is given. Solution: - Update all logging calls to use the custom logger. - Skip initialization of winstonLogger if a custom logger is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to vscode-neovim/vscode-neovim#134
current logger only allows customizable behavior via env variable which works for majority of node.js entrypoint, but some cases (like vs code extension) overriding env variable is not very much feasible cases.
NeovimClientctor already accepts custom logger, butattachdoes not exposes it - this PR expands signature toattachto allow specify options for customizing points.Instead of expanding param to directly accepts
logger, it acceptsoptionsobject instead for possible future customizations.