Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrainVal split usage #64

Closed
lukasHoel opened this issue Oct 11, 2022 · 2 comments
Closed

TrainVal split usage #64

lukasHoel opened this issue Oct 11, 2022 · 2 comments

Comments

@lukasHoel
Copy link

Hi,

thanks for the awesome project!

according to kwea123/ngp_pl#1 and NVlabs/instant-ngp#745 only the train-split was used in Instant-NGP's results.

Do you also have the numbers for only using the train split? :)

@liruilong940607
Copy link
Collaborator

Oh thanks for pointing it out Lukas! I didn't notice this clarification so thought it was using trainval split.

So I did a quick test on Chair, using train test gives me 35.17db, comparing to 36.13db on trainval set. For reference NGP paper reports 35.00db for this scene. (5mins)

Still, the NGP paper uses random bkgd argumentation I think (at least that is by default enabled in their code base). And I believe that would give some boost to the performance.

We will do a full test soon.

@liruilong940607
Copy link
Collaborator

Hi we did a full test in #68. Turns out under the fair comparison setting, both the performance and runtime are nearly the same. Sorry for the confusing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants