Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masked (mustard) dataset much slower with main than PR2025 #2075

Closed
machenmusik opened this issue Jun 14, 2023 · 5 comments · Fixed by #2110
Closed

masked (mustard) dataset much slower with main than PR2025 #2075

machenmusik opened this issue Jun 14, 2023 · 5 comments · Fixed by #2110

Comments

@machenmusik
Copy link
Contributor

machenmusik commented Jun 14, 2023

On my machine

@machenmusik
Copy link
Contributor Author

Suggested viewer crop settings for mustard:

Enable
Crop Min -0.15 -0.20 -0.25
Crop Max 0.15 0.20 0.33

@machenmusik
Copy link
Contributor Author

d4b0437 is 80 to 90ms
3b0f758 is ~400ms

So looks to be a side effect of #1730 for datasets using masks.

@machenmusik
Copy link
Contributor Author

Removing "mask" from https://github.com/nerfstudio-project/nerfstudio/blob/main/nerfstudio/data/datasets/base_dataset.py#L45 restores full speed for mustard dataset.

Perhaps there should be a parameter to request masks on GPU that would do the above at runtime.

@machenmusik machenmusik changed the title mustard dataset much slower with main than PR2025 masked (mustard) dataset much slower with main than PR2025 Jun 14, 2023
@YifuTao
Copy link

YifuTao commented Jun 16, 2023

I faced similar issue. The training speed drops from 170k/s to 6k/s so more than 20 times slower. Indeed #1730 reduced GPU memory when using mask, but the speed is compromised

@machenmusik
Copy link
Contributor Author

#2110 should resolve this when the new option is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants