New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth outputs are z-depth for Gaussians but distances for nerfacto (and everything else) #2743

Open

brentyi opened this issue Jan 10, 2024 · 2 comments

Collaborator

brentyi commented Jan 10, 2024

No description provided.

Collaborator

jb-ye commented Jan 12, 2024

I also mentioned here: nerfstudio-project/gsplat#99

Contributor

pwais commented Jan 16, 2024

depth loss currently supports z-depth:

nerfstudio/nerfstudio/models/depth_nerfacto.py

Line 133 in 32939e0

if not self.config.is_euclidean_depth:

once upon a time the depth_dataset I believe did too but i guess that got broken, i don't see it e.g. being forwarded to the model :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment