Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage counts are actually UsageRevision counts #130

Open
nschneid opened this issue Jul 30, 2018 · 5 comments
Open

Usage counts are actually UsageRevision counts #130

nschneid opened this issue Jul 30, 2018 · 5 comments
Assignees
Labels

Comments

@nschneid
Copy link
Contributor

See b17c7bb#commitcomment-29874556

1126fd4 may solve the problem but the solution requires Django 2.x. (#45)

@nschneid
Copy link
Contributor Author

Still an issue:

At http://flat.nert.georgetown.edu/ko/, it says hanthey has 14 construals

But http://flat.nert.georgetown.edu/ko/%ED%95%9C%ED%85%8C/ shows 4 construals

@nitinvwaran
Copy link
Contributor

i could take a look at this?

@nschneid
Copy link
Contributor Author

You could try. It involves a complicated query.

@nitinvwaran
Copy link
Contributor

Looking at the generated SQL, i thought of a fix where the distinct construal list in the usage revision table is used for the counts. The hanthey count in both the pages is now 4, and the German 'an' count is 7.

I've attached the SQL generated by django, after the fix.
query.sql.txt

Raised a PR #217

@nschneid
Copy link
Contributor Author

The counts are still not always correct: e.g. http://flat.nert.georgetown.edu/ko/ shows

image

while http://flat.nert.georgetown.edu/ko/%EC%97%90/ lists only 9 usages. (Could the 10th be a deprecated/deleted one?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants