[HOLD] feat: default lock script use recoverable signing #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using secp256k1 recoverable signing, we can significantly reduce tx size by removing the pubkey from tx witness. The total cycles for verification increased from 2660252 to 2739437 for a typical 2-in-2-out tx. discussion is on nervosnetwork/ckb-system-scripts#15 The default secp256k1_blake160_sighash_all lock script is compiled from the following source: https://github.com/nervosnetwork/ckb-system-scripts/blob/517e667a3ce496b58ba948e22b34d1e5c9e79710/c/secp256k1_blake160_sighash_all.c The exact gcc version used in the compilation can be located in the following docker image: xxuejie/riscv-gnu-toolchain-rv64imac: 20190606
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
|
@zhangsoledad is assigned as the chief reviewer |
doitian
requested changes
Jun 14, 2019
This was referenced Jun 18, 2019
Merged
doitian
added a commit
that referenced
this pull request
Jun 18, 2019
1. Replace system cell to another repo 2. cherry pick #1012 to this pr BREAKING CHANGE: It changes the default secp256k1 script, which now uses recoverable signature. Co-authored-by: Jiang Jinyang <jjyruby@gmail.com> Co-authored-by: driftluo <driftluo@foxmail.com>
This was referenced Jun 21, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using secp256k1 recoverable signing, we can significantly reduce tx size by removing the pubkey from tx witness. The total cycles for verification increased from 2660252 to 2739437 for a typical 2-in-2-out tx. discussion is on nervosnetwork/ckb-system-scripts#15
The default secp256k1_blake160_sighash_all lock script is compiled
from the following source:
https://github.com/nervosnetwork/ckb-system-scripts/blob/517e667a3ce496b58ba948e22b34d1e5c9e79710/c/secp256k1_blake160_sighash_all.c
The exact gcc version used in the compilation can be located in the
following docker image:
xxuejie/riscv-gnu-toolchain-rv64imac: 20190606