feat: add set_network_active rpc
#2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
doitian,
keroro520,
yangby-cryptape and
zhangsoledad
as code owners
keroro520
previously approved these changes
Jul 1, 2020
TheWaWaR
previously approved these changes
Jul 29, 2020
doitian
previously approved these changes
Jul 30, 2020
CKB - Pull Requests
automation
moved this from 👀 Awaiting review
to ✅ Reviewer approved
Jul 30, 2020
|
bors r=TheWaWaR,keroro520 |
|
bors r=TheWaWaR,keroro520 |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2144: feat: add `set_network_active` rpc r=TheWaWaR,keroro520 a=quake allows user to pause and restart p2p network message processing through rpc 2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2184: feat: tx_pool_info include tip hash r=quake,doitian a=keroro520 The state of the transaction pool is related to the chain tip. So attaching `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info` makes it more rigorous. Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: keroro <keroroxx520@gmail.com>
|
Build failed (retrying...):
|
quake
force-pushed
the
quake/network-active
branch
from
f689128
to
454901b
Compare
CKB - Pull Requests
automation
moved this from ✅ Reviewer approved
to 👀 Awaiting review
Jul 30, 2020
|
@doitian , @TheWaWaR , @keroro520 rebased with dev branch, please review again, thanks |
TheWaWaR
reviewed
Jul 30, 2020
TheWaWaR
approved these changes
Jul 30, 2020
keroro520
approved these changes
Jul 30, 2020
doitian
approved these changes
Jul 30, 2020
CKB - Pull Requests
automation
moved this from 👀 Awaiting review
to ✅ Reviewer approved
Jul 30, 2020
|
bors r=doitian,TheWaWaR,keroro520 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows user to pause and restart p2p network message processing through rpc