feat: tx_pool_info include tip hash #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR adds `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info`.
keroro520
requested review from
doitian,
quake,
yangby-cryptape and
zhangsoledad
as code owners
|
LGTM, please resolve CI fmt issue. |
quake
previously approved these changes
Jul 27, 2020
keroro520
force-pushed
the
tx-pool-info-include-tip-hash
branch
from
2df3c46
to
08a823d
Compare
quake
approved these changes
Jul 28, 2020
doitian
approved these changes
Jul 30, 2020
|
bors r=quake,doitian |
1 similar comment
|
bors r=quake,doitian |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2144: feat: add `set_network_active` rpc r=TheWaWaR,keroro520 a=quake allows user to pause and restart p2p network message processing through rpc 2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2184: feat: tx_pool_info include tip hash r=quake,doitian a=keroro520 The state of the transaction pool is related to the chain tip. So attaching `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info` makes it more rigorous. Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: keroro <keroroxx520@gmail.com>
|
Build failed (retrying...):
|
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2184: feat: tx_pool_info include tip hash r=quake,doitian a=keroro520 The state of the transaction pool is related to the chain tip. So attaching `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info` makes it more rigorous. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: keroro <keroroxx520@gmail.com>
|
bors r=quake,doitian |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state of the transaction pool is related to the chain tip. So attaching
tip_hashandtip_numberintoTxPoolInfowhich returns by RPCtx_pool_infomakes it more rigorous.