small tx-pool refactoring #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
changed the title
zhangsoledad
changed the title
zhangsoledad
requested review from
doitian,
keroro520,
quake and
yangby-cryptape
as code owners
doitian
added
the
p:must-have
doitian
requested changes
Jul 22, 2020
zhangsoledad
force-pushed
the
zhangsoledad/tx-pool-fix
branch
from
69f3956
to
5104e18
Compare
zhangsoledad
force-pushed
the
zhangsoledad/tx-pool-fix
branch
2 times, most recently
from
ebcef84
to
e9d186a
Compare
quake
previously approved these changes
Jul 27, 2020
doitian
previously approved these changes
Jul 30, 2020
CKB - Pull Requests
automation
moved this from 👀 Awaiting review
to ✅ Reviewer approved
Jul 30, 2020
|
bors r=quake,doitian |
1 similar comment
|
bors r=quake,doitian |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2144: feat: add `set_network_active` rpc r=TheWaWaR,keroro520 a=quake allows user to pause and restart p2p network message processing through rpc 2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2184: feat: tx_pool_info include tip hash r=quake,doitian a=keroro520 The state of the transaction pool is related to the chain tip. So attaching `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info` makes it more rigorous. Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: keroro <keroroxx520@gmail.com>
|
Build failed (retrying...):
|
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2184: feat: tx_pool_info include tip hash r=quake,doitian a=keroro520 The state of the transaction pool is related to the chain tip. So attaching `tip_hash` and `tip_number` into `TxPoolInfo` which returns by RPC `tx_pool_info` makes it more rigorous. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: keroro <keroroxx520@gmail.com>
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit Co-authored-by: zhangsoledad <787953403@qq.com>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2197: fix: should exit with error code when setup failed r=quake,doitian a=yangby-cryptape Issue: if the config was malformed and an error was thrown in `setup_app`, the process wouldn't exit. 2198: chore: several minor changes about thread and runtime r=quake,driftluo a=yangby-cryptape - Simplify dependencies of `ckb-async-runtime`. - Use `::std::sync::Barrier` instead of `crossbeam-channel`. - Let method `ckb-async-runtime::new_runtime` more general. - Accept name prefix for threads. - Accept `tokio::runtime::Builder` as an optional parameter, so we can set options for the runtime. - After we upgrade `tokio` from 0.1 to 0.2, the thread name of `tokio` runtime threads has a redundant suffix "-". - [`tokio-0.1.x::runtime::Builder::name_prefix(...)`](https://docs.rs/tokio/0.1.22/tokio/runtime/struct.Builder.html#method.name_prefix) - [`tokio-0.2.x::runtime::Builder::thread_name(...)`](https://docs.rs/tokio/0.2.22/tokio/runtime/struct.Builder.html#method.thread_name) - Use a default thread name in logs instead of an empty string. Without color, a log record with empty thread name is a bit hard to parse. - Give name to rayon threads to improve the debuggability slightly. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
|
Build failed (retrying...):
|
bors bot
added a commit
that referenced
this pull request
Jul 31, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit Co-authored-by: zhangsoledad <787953403@qq.com>
|
Build failed:
|
zhangsoledad
force-pushed
the
zhangsoledad/tx-pool-fix
branch
from
e9d186a
to
2701205
Compare
|
benchmark |
Benchmark Result
|
quake
approved these changes
Aug 3, 2020
driftluo
approved these changes
Aug 3, 2020
|
bors r=quake,doitian |
bors bot
added a commit
that referenced
this pull request
Aug 3, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit Co-authored-by: zhangsoledad <787953403@qq.com>
|
Build failed:
|
|
bors retry |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Nov 20, 2020
2370: chore: upgrade futures and console r=yangby-cryptape,zhangsoledad a=driftluo
`futures` changelog:
```
Switch proc-macros to use native #[proc_macro] at Rust 1.45+ (#2243)
Add WeakShared (#2169)
Add TryStreamExt::try_buffered (#2245)
Add StreamExt::cycle (#2252)
Implemented Clone for stream::{Empty, Pending, Repeat, Iter} (#2248, #2252)
Fix panic in some TryStreamExt combinators (#2250)
```
Unified console to 0.12
Fix warning on `fixed-hash-core`
Co-authored-by: driftluo <driftluo@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal changes: