RFC33: ckb vm version1 changes #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #235, it's planned to use PR number as the RFC number. If you have multiple RFCs to submit, please split it into multiple PRs. |
doitian
reviewed
May 27, 2021
doitian
reviewed
May 27, 2021
doitian
reviewed
May 28, 2021
|
Please mention #232 how the node selects VM versions. |
|
For vm version 1 in CKB, one special rule can be added. If the loaded ELF has an ELF section named “.ckb.forks”, CKB-VM will skip executing the binary, and just treat the program as always success script. The consumed cycles are just the ones used to load the script and boot the VM. CKB nodes of the next fork version (ckb2021) should not relay transactions with ".ckb.forks" section because they cannot verify it. |
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Jul 1, 2021
2756: feat(hardfork): ckb2021 hardfork features (vm related part) r=doitian,quake a=yangby-cryptape ### Changes - New hardfork Features - [CKB-RFCs PR 236: RFC: ckb vm version1 changes](nervosnetwork/rfcs#236) - [CKB-RFCs PR 237: RFC: vm syscalls 2](nervosnetwork/rfcs#237) - [CKB-RFCs PR 238: CKB VM version selection](nervosnetwork/rfcs#238) - All changes are followed to the latest RFCs, except: - Add a "edition" field to all configuration files: CKB chain specification or app configurations. #### CKB Chain Edition - If no `edition` field, the default edition is `"2019"`. - After this PR, the default files created by `ckb init` will be edition `"2021"` files. But the public chains will still use the edition `"2019"` CKB chain specification as the built-in spec. At present, there are only to public chains: "mainnet" and "testnet". - The edition `"2019"` doesn't support hardfork parameters. - How to upgrade from edition `"2019"` to `"2021"`? Modify your spec file (default is `specs/dev.toml`), `ckb.toml` and `ckb-miner.toml`: - Update all `hash_type = "data"` to `hash_type.kind = "data"` and `hash_type.vm_version = 0`. - Update all `hash_type = "type"` to `hash_type.kind = "type"`. - Insert `edition = "2021"` into the head of the files. After upgrade the edition of chain specification, the first time to run the CKB, you have to use `--overwrite-spec` parameter. The details of this parameter can be found with `ckb run --help`. ### BREAKING CHANGES - The field `hash_type` in `Script` is changed from a `String` to an `Object` for all JSON RPC methods. The details can be found in the latest RFCs. - The argument `--ba-hash-type` for `ckb init` is split into two arguments: `--ba-hash-type-kind` and `--ba-hash-type-vm-version`. More details can be found with `ckb-release init --help`. Co-authored-by: mohanson <mohanson@outlook.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
|
Please change RFC numbers according to #246 . Sorry for the inconvenience. |
quake
approved these changes
Mar 3, 2022
doitian
approved these changes
Mar 4, 2022
doitian
added
the
s:fcp
doitian
approved these changes
Mar 4, 2022
quake
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.