-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC32: CKB VM version selection #238
Merged
doitian
merged 8 commits into
nervosnetwork:master
from
doitian:ckb-vm-version-selection
Apr 1, 2022
Merged
RFC32: CKB VM version selection #238
doitian
merged 8 commits into
nervosnetwork:master
from
doitian:ckb-vm-version-selection
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Jul 1, 2021
2756: feat(hardfork): ckb2021 hardfork features (vm related part) r=doitian,quake a=yangby-cryptape ### Changes - New hardfork Features - [CKB-RFCs PR 236: RFC: ckb vm version1 changes](nervosnetwork/rfcs#236) - [CKB-RFCs PR 237: RFC: vm syscalls 2](nervosnetwork/rfcs#237) - [CKB-RFCs PR 238: CKB VM version selection](nervosnetwork/rfcs#238) - All changes are followed to the latest RFCs, except: - Add a "edition" field to all configuration files: CKB chain specification or app configurations. #### CKB Chain Edition - If no `edition` field, the default edition is `"2019"`. - After this PR, the default files created by `ckb init` will be edition `"2021"` files. But the public chains will still use the edition `"2019"` CKB chain specification as the built-in spec. At present, there are only to public chains: "mainnet" and "testnet". - The edition `"2019"` doesn't support hardfork parameters. - How to upgrade from edition `"2019"` to `"2021"`? Modify your spec file (default is `specs/dev.toml`), `ckb.toml` and `ckb-miner.toml`: - Update all `hash_type = "data"` to `hash_type.kind = "data"` and `hash_type.vm_version = 0`. - Update all `hash_type = "type"` to `hash_type.kind = "type"`. - Insert `edition = "2021"` into the head of the files. After upgrade the edition of chain specification, the first time to run the CKB, you have to use `--overwrite-spec` parameter. The details of this parameter can be found with `ckb run --help`. ### BREAKING CHANGES - The field `hash_type` in `Script` is changed from a `String` to an `Object` for all JSON RPC methods. The details can be found in the latest RFCs. - The argument `--ba-hash-type` for `ckb init` is split into two arguments: `--ba-hash-type-kind` and `--ba-hash-type-vm-version`. More details can be found with `ckb-release init --help`. Co-authored-by: mohanson <mohanson@outlook.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
yangby-cryptape
suggested changes
Jul 13, 2021
rfcs/0232-ckb-vm-version-selection/0232-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
313fba7
to
ad56110
Compare
ad56110
to
6ff00a9
Compare
6ff00a9
to
a112313
Compare
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
yangby-cryptape
suggested changes
Jul 23, 2021
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
…on.md Co-authored-by: Boyu Yang <yangby@cryptape.com>
doitian
commented
Jul 24, 2021
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
doitian
commented
Jul 24, 2021
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
doitian
added a commit
to doitian/rfcs
that referenced
this pull request
Aug 3, 2021
closes https: //github.com/nervosnetwork/pull/238#discussion_r675663889
57562ad
to
1730abb
Compare
xxuejie
reviewed
Mar 3, 2022
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
Assigned reviewers: @xxuejie @zhangsoledad |
zhangsoledad
reviewed
Mar 4, 2022
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Outdated
Show resolved
Hide resolved
Co-authored-by: zhangsoledad <787953403@qq.com>
xxuejie
approved these changes
Mar 17, 2022
zhangsoledad
approved these changes
Mar 17, 2022
FCP will end on 2022-04-01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
b:consensus
Break consensus
ckb2021
Hard fork scheduled in 2021
hard-fork
s:fcp
Final Comment Period. PR is merged when there's no comments in 14 days.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.