Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving and running in succession rapidly leaves the save banner visible during play #1911

Open
massung opened this issue May 4, 2022 · 5 comments
Labels

Comments

@massung
Copy link

massung commented May 4, 2022

Just hit ctrl-s and then ctrl-r back-to-back quickly.

Screen.Recording.2022-05-04.at.8.44.32.AM.mov
@joshgoebel joshgoebel added the bug label Dec 5, 2022
@AlecTroemel
Copy link
Contributor

FWIW im unable to reproduce this running 2a662a0 on Linux

@sogaiu
Copy link

sogaiu commented Jan 28, 2023

I believe it happens for me with eb4e331

Will try the latest.

Ah no -- I misinterpreted. It doesn't happen for me.

I guess the video is showing an artifacted banner that remains on the screen. That doesn't happen for me.

@Skeptim
Copy link
Contributor

Skeptim commented Aug 24, 2023

This happens to me with carts in which I don't use cls in TIC() like https://tic80.com/play?cart=3430. It does not happen otherwise, which makes sense.

@AlecTroemel
Copy link
Contributor

@TimotheeGreg thats a good catch! @massung its been a while since the original issue was opened, but do you think the original example cart could be missing a cls call?

@massung
Copy link
Author

massung commented Aug 24, 2023

It was a while and I don't have it for reference any more (sorry).

But, I'm fairly confident that yes - it wasn't calling cls each frame. However, if that was the case then it was drawing the entire frame such that it shouldn't have been needed.

I've downloaded the 1.0 version and tried replacing cls in the startup script with rect over the entire screen and everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants