Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line 145 wrong on Neslib.FastMath.Sse2_64.inc #3

Closed
wesleybobato opened this issue May 28, 2020 · 1 comment
Closed

line 145 wrong on Neslib.FastMath.Sse2_64.inc #3

wesleybobato opened this issue May 28, 2020 · 1 comment

Comments

@wesleybobato
Copy link

Hi Erik
It looks like you need to replace

movq xmm0, [ARadians]
per
movlps xmm0, [ARadians]

Thanks. :)
@neslib
Copy link
Owner

neslib commented May 28, 2020

Well spotted. Thanks!
Although technically, both movq and movlps work in this case, movlps should be used because it is designed for floating-point values. I did that in all other places, but forgot it here.

@neslib neslib closed this as completed May 28, 2020
neslib pushed a commit that referenced this issue May 28, 2020
@erikvanbilsen
Fixued issue #3 (movq should be movlps)
c0cd159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neslib @wesleybobato