Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the installation of CPPCHECK and CLANG-FORMAT to .travis.yml #759

Closed
lekshmideepu opened this issue Jun 20, 2017 · 4 comments
Closed
Assignees
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL

Comments

@lekshmideepu
Copy link
Contributor

lekshmideepu commented Jun 20, 2017

As we have $xSTATIC_ANALYSIS enabled for all our builds, do we need this ?

Also I think we could move the installations of CPPCHECK and CLANG-FORMAT from build.sh to the package installation section in .travis.yml where we install all the other packages.

@heplesser heplesser added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: Pending DO NOT USE THIS LABEL S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Jun 21, 2017
@lekshmideepu
Copy link
Contributor Author

I have successfully moved the installation to the yaml file and the build is fine except the final build summary table as it depends on the MSGBLDxxxx numbers created by @gtrensch
Made necessary changes in the build.sh file and have to do the changes in extras/parse_travis_log.py

@gtrensch
Copy link
Contributor

Generally, moving all the installation to the yml-file is a good idea. $STATIC_ANALYSIS is always set in the build matrix and can probably be removed too.

The MSGBLDxxxx message numbers indicate the status of the code analysis tool installation process. They are needed to evaluate the build by the parser script.

@gtrensch
Copy link
Contributor

@lekshmideepu A note on the message numbers: Parsing log files or console outputs is always a proplem. From a software engineering perspective it introduces dependencies and a coupling which you actually want to avoid. The previous implementation relied on the message texts itself. Means, fixing a typo could mess up the log parser. So I intruduced the numbers. You may move and change the messages but not the mumbers. If so doing, you need to take care of their dependencies with the python log parser.

@heplesser
Copy link
Contributor

Fixed by #789.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Development

No branches or pull requests

5 participants