Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parrot_neuron should exploit spike multiplicity #82

Closed
heplesser opened this issue Aug 14, 2015 · 3 comments
Closed

parrot_neuron should exploit spike multiplicity #82

heplesser opened this issue Aug 14, 2015 · 3 comments

Comments

@heplesser
Copy link
Contributor

parrot_neuron currently emits spikes using a loop

for ( ulong_t i_spike = 0; i_spike < current_spikes_n; i_spike++ )
  network()->send( *this, se, lag );

This is inefficient---why don't we use multiplicity and make just a single network->send() call?
flinz added a commit to flinz/nest-simulator that referenced this issue Oct 16, 2015
@flinz
Changed parrot neuron to emit multiple spikes via spike multiplicity …
ff0cb6d 
…instead of a loop; Addresses nest#82
@flinz
Copy link
Contributor

flinz commented Oct 16, 2015

Since i am already working on the parrot_neuron, I changed this to use multiplicity (see the branch https://github.com/flinz/nest-simulator/tree/issue-parrot_neuron-multiplicity) and added a test to confirm.

This branch is based off my branch already containing new tests for the parrot neuron (https://github.com/flinz/nest-simulator/tree/parrot-multiport), so I will open a pull request once that one is merged.

flinz added a commit to flinz/nest-simulator that referenced this issue Nov 3, 2015
@flinz
Squashed commit of the following:
a5b3832 
commit b840820
Merge: 4668ea2 ce63c55
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 15:53:36 2015 +0100

    Merge branch 'master' into issue-parrot_neuron-multiplicity

    * master:

commit 4668ea2
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 15:29:13 2015 +0100

    Updated tests to conform to changes in parrot-multipart branch;

commit 1b8ddac
Merge: bce4bf9 9c4c2f3
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 15:27:01 2015 +0100

    Merge branch 'parrot-multiport' into issue-parrot_neuron-multiplicity

    * parrot-multiport:
      removed unnecessary variables gid_source and gid_parrot;

commit bce4bf9
Merge: ef31ab0 3d8da20
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 13:20:45 2015 +0100

    Merge branch 'parrot-multiport' into issue-parrot_neuron-multiplicity

    * parrot-multiport:
      Added tests for STDP protocols between parrot neurons to potentiate and depress connection; Accounted for delays in simulation times; Addresses https://github.com/nest/nest-simulator/pull/118/files#r43736299 and https://github.com/nest/nest-simulator/pull/118/files#r43702948; Fixes https://github.com/nest/nest-simulator/pull/118/files#r43702538 and nest#118 (comment);
      Import GetStatus/SetStatus from the info component, where they were moved in a3ec4d4.
      Fix the stop condition of process_static_analysis.
      Added explanation for recursive import code.
      Moved Get/SetStatus from node to info component of HL API.
      Added information on steps to execute after creating the release tarball.
      Validate parameter values in setters of tsodyks synapses
      Added empty __init__.py to make the lib directory a module.
      Split Python high-level API into multiple files and made loading of the submodules dynamic
      Tsodyks synapse model with common properties

commit ef31ab0
Merge: ca70656 9425619
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 10:19:25 2015 +0100

    Merge branch 'parrot-multiport' into issue-parrot_neuron-multiplicity

    * parrot-multiport:

commit ca70656
Merge: 48a9feb c80a8be
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Tue Nov 3 10:18:11 2015 +0100

    Merge branch 'master' into issue-parrot_neuron-multiplicity

    * master:
      Apply @lekshmideepu suggestions
      Filter out empty entries in changed files
      some cleanup
      Modify travis.yml
      Implemented two fixes for the K computer:
      Print status about uploading to S3
      Remove cppcheck files after static analysis.
      Adjust comment and have starting and ending line at summary
      Correct copyright header.
      Add a script to parse travis log and give a nice summary.
      Removed superfluous and outdated files

commit 48a9feb
Merge: 0b96cd1 4d939e5
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Mon Oct 19 10:14:01 2015 +0200

    Merge branch 'parrot-multiport' into issue-parrot_neuron-multiplicity

    * parrot-multiport:
      Added superclass (archiving_node) get_status to parrot_neuron;

commit 0b96cd1
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Fri Oct 16 16:08:11 2015 +0200

    added test for parrot neuron multiplicity.

commit ff0cb6d
Author: Alex Seeholzer <seeholzer@gmail.com>
Date:   Fri Oct 16 15:39:45 2015 +0200

    Changed parrot neuron to emit multiple spikes via spike multiplicity instead of a loop; Addresses nest#82
@flinz flinz mentioned this issue Nov 3, 2015
Merged
This was referenced Nov 3, 2015
Merged
Closed
jougs added a commit that referenced this issue Nov 5, 2015
@jougs
Merge pull request #146 from flinz/issue-parrot_neuron-multiplicity-s…
ca0513f 
…quashed

Fix issue #82: parrot neuron now emits multiple spikes via spike multiplicity instead of a loop
@flinz
Copy link
Contributor

flinz commented Nov 5, 2015

@heplesser I think this can be closed, since a fix was merged.

@jougs
Copy link
Contributor

jougs commented Nov 5, 2015

Definitely.

@jougs jougs closed this as completed Nov 5, 2015
@heplesser heplesser mentioned this issue Dec 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flinz @heplesser @jougs