Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in JURON CMake file #1040

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Fix bug in JURON CMake file #1040

merged 2 commits into from
Nov 26, 2018

Conversation

ikitayama
Copy link

Supply appropriate flags to OpenMP_C_FLAGS as well, depending on the offload value.

@heplesser heplesser added T: Enhancement New functionality, model or documentation ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 5, 2018
@heplesser
Copy link
Contributor

A single reviewer suffices on this PR as it concerns only a specific machine.

@ikitayama
Copy link
Author

@gtrensch would you review this PR?

@ikitayama
Copy link
Author

@gtrensch - would you review this PR when you have time? Thanks!

gtrensch
gtrensch approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this contribution!
Unfortunately, I am unable to test the build on JURON. Nevertheless, the changes look good to me and I approve this PR.

@heplesser heplesser merged commit 0211404 into nest:master Nov 26, 2018
@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation and removed T: Enhancement New functionality, model or documentation labels Mar 8, 2019
@terhorstd terhorstd changed the title JURON CMake file bug fix Fix bug in JURON CMake file Jun 26, 2019
@ikitayama ikitayama deleted the cmake-files-juron branch November 28, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ikitayama @heplesser @gtrensch @terhorstd