Use shape as argument instead of columns/rows/depth and update topology examples to NEST3 #1287
Conversation
| # generate list of 12 (x,y) pairs | ||
| pos = [[random.uniform(-0.75, 0.75), random.uniform(-0.5, 0.5)] | ||
| for j in range(12)] | ||
| pos = nest.spatial.free([[random.uniform(-0.75, 0.75), random.uniform(-0.5, 0.5)] |
There was a problem hiding this comment.
maybe use nest.random.uniform here?
There was a problem hiding this comment.
@Silmathoron with the new NEST-3 we have made random distributions from NEST accessible from PyNEST, and seeing as this is an example I think we should use the NEST version.
There was a problem hiding this comment.
The problem here is that we want different distributions for different dimensions, which currently can't be done when passing nest.random functions to nest.spatial.free(). But it shouldn't be difficult to add this, maybe after this PR is merged, then we can update this example.
There was a problem hiding this comment.
Yesterday, I asked @hakonsbm about this and he recommended to use numpy.random.uniform in this case because with nest.random.uniform it is apparently not possible, yet, to define different min and max for the two dimensions. If there is a better solution, please let me know and I will adjust it.
There was a problem hiding this comment.
Yes, passing a nest.random function to nest.spatial.free() will currently use the same distribution in all dimensions. But it shouldn't be difficult to add the possibility to have different distributions for different dimensions. Maybe after this PR is merged, then we can update this example?
stinebuu
added
ZC: PyNEST
| # generate list of 12 (x,y) pairs | ||
| pos = [[random.uniform(-0.75, 0.75), random.uniform(-0.5, 0.5)] | ||
| for j in range(12)] | ||
| pos = nest.spatial.free([[random.uniform(-0.75, 0.75), random.uniform(-0.5, 0.5)] |
There was a problem hiding this comment.
The problem here is that we want different distributions for different dimensions, which currently can't be done when passing nest.random functions to nest.spatial.free(). But it shouldn't be difficult to add this, maybe after this PR is merged, then we can update this example.
This PR replaces the arguments
columns/rows/depthused previously for creating grid layers with a single array namedshape.shapecan be of length 2 or 3 for 2D or 3D layers, respectively. The grid mask and its anchor are also adapted.Topology examples are now updated to NEST3 and moved to pynest/examples/spatial.