-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clang warnings #2201
Fix Clang warnings #2201
Conversation
and delete impl-files thus superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup. I did not follow each move individually, but trust the fact that the CI is happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just have one very minor formatting suggestion.
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR fixes a large number of warnings emitted by Apple Clang. Almost all of these warnings were due to explicit template class instantiations for Datum types, which could be removed by moving minimal methods from
_impl.h
files to.h
files. This allowed removal of several_impl.h
and.cc
files.