Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python codestyle #2223

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Fix Python codestyle #2223

merged 5 commits into from
Dec 1, 2021

Conversation

clinssen
Copy link
Contributor

This fixes the static code check failure that is completely unrelated to but suddenly cropping up in #2058.

Also remove some unittest assertions in favour of plain Python assertions (as recommended for unittest → pytest migration).

jougs
jougs approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus my minor comments. Still approving, trusting that you'll like them ;-)

testsuite/pytests/test_sp/test_sp_manager.py Outdated Show resolved Hide resolved
testsuite/pytests/test_sp/test_sp_manager.py Outdated Show resolved Hide resolved
testsuite/pytests/test_sp/test_sp_manager.py Outdated Show resolved Hide resolved
@jougs jougs added I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 29, 2021
@jougs jougs added this to In progress in Automated testing via automation Nov 29, 2021
@jougs jougs added this to the NEST 3.2 milestone Nov 29, 2021
@jougs jougs added this to In progress in PyNEST via automation Nov 29, 2021
clinssen and others added 3 commits November 29, 2021 19:31
@clinssen @jougs
Update testsuite/pytests/test_sp/test_sp_manager.py
a518f1b 
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
@clinssen @jougs
Update testsuite/pytests/test_sp/test_sp_manager.py
4f52c5d 
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
@clinssen @jougs
Update testsuite/pytests/test_sp/test_sp_manager.py
0b6fe4d 
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
jougs
jougs approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two additional minor suggestions

testsuite/pytests/test_sp/test_sp_manager.py Outdated Show resolved Hide resolved
testsuite/pytests/test_sp/test_sp_manager.py Outdated Show resolved Hide resolved
Automated testing automation moved this from In progress to Reviewer approved Dec 1, 2021
PyNEST automation moved this from In progress to Review Dec 1, 2021
@jougs
Copy link
Contributor

jougs commented Dec 1, 2021

Merging without second review due to simplicity of changes.

@jougs jougs merged commit 340e004 into nest:master Dec 1, 2021
Automated testing automation moved this from Reviewer approved to Done Dec 1, 2021
PyNEST automation moved this from Review to Done Dec 1, 2021
@jougs jougs changed the title Fix pycodestyle Fix Python codestyle Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
  
Done
Automated testing
  
Done
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clinssen @jougs