-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python codestyle #2223
Fix Python codestyle #2223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus my minor comments. Still approving, trusting that you'll like them ;-)
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two additional minor suggestions
Merging without second review due to simplicity of changes. |
This fixes the static code check failure that is completely unrelated to but suddenly cropping up in #2058.
Also remove some unittest assertions in favour of plain Python assertions (as recommended for unittest → pytest migration).