Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nest-server command #2225

Merged
merged 10 commits into from
Jan 17, 2022
Merged

Update nest-server command #2225

merged 10 commits into from
Jan 17, 2022

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Dec 1, 2021 •
edited

This PR updates the nest-server command.

It includes:

  • to configure buffer size for uwsgi
  • to configure nest-server using environment variable -> useful for docker-compose or openShift.
  • sort options in doc alphabetically
  • set options for uwsgi
  • rename NEST Server to NEST Simulator in docs. It is more accurate that it is the server of NEST Simulator.

@stinebuu stinebuu added I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Dec 6, 2021
@stinebuu stinebuu added this to In progress in PyNEST via automation Dec 6, 2021
@stinebuu stinebuu added this to the NEST 3.2 milestone Dec 6, 2021
@stinebuu stinebuu moved this from In progress to Review in PyNEST Dec 6, 2021
terhorstd
terhorstd requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, some small changes to have a look at.

bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
bin/nest-server Outdated Show resolved Hide resolved
jougs
jougs approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Many thanks for the update

@jougs jougs requested a review from terhorstd December 14, 2021 10:31
@heplesser
Copy link
Contributor

The test failure above is just due to Clang 13 compiler warnings (fixed by #2231), so this can be merged in spite of the failing macos test.

@jougs
Copy link
Contributor

jougs commented Dec 15, 2021

@babsey: can you please merge upstream/master?
@terhorstd: can you please quickly indicate if you're fine with the current state?

@babsey
Copy link
Contributor Author

babsey commented Dec 15, 2021

@babsey: can you please merge upstream/master?

Done

terhorstd
terhorstd requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny suggestions, but looks good to me.

bin/nest-server Outdated Show resolved Hide resolved
babsey and others added 2 commits January 17, 2022 17:52
@babsey @terhorstd
Apply suggestions from code review
9c84658 
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
@babsey
Correct env for nest-server
3abb8f1
terhorstd
terhorstd approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @babsey !

@terhorstd terhorstd merged commit 429d850 into nest:master Jan 17, 2022
PyNEST automation moved this from Review to Done Jan 17, 2022
@babsey babsey deleted the nest-server-command branch January 18, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
PyNEST
  
Done
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@babsey @heplesser @jougs @terhorstd @stinebuu