Fix compiler warning issued by newest Clang #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
heplesser
changed the title
|
I reduced to MINIMAL testing on macOS again. For some reason, Cmake does not find how to compile with OpenMP on the test runner, even though that should work with |
jougs
approved these changes
Dec 8, 2021
hakonsbm
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Looks good to me! However, I can also add that I found this stackoverflow post which seems to suggest that the warning is due to a defect in the wording of the standard:
https://stackoverflow.com/questions/68751682/is-a-class-templates-name-in-scope-for-a-qualified-out-of-line-destructors-def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compiler warning introduced by the last version of Clang (see https://windowsquestions.com/2021/08/12/is-the-class-name-in-same-scope-as-the-out-of-line-definition-of-class-templates-destructor/), which made all macOS tests fail (zero warnings expected).
I am setting this to critical with Milestone 3.2 because all tests will fail in macOS until this is fixed.