-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warning issued by newest Clang #2231
Conversation
I reduced to MINIMAL testing on macOS again. For some reason, Cmake does not find how to compile with OpenMP on the test runner, even though that should work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks for taking care!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! However, I can also add that I found this stackoverflow post which seems to suggest that the warning is due to a defect in the wording of the standard:
https://stackoverflow.com/questions/68751682/is-a-class-templates-name-in-scope-for-a-qualified-out-of-line-destructors-def
This PR fixes a compiler warning introduced by the last version of Clang (see https://windowsquestions.com/2021/08/12/is-the-class-name-in-same-scope-as-the-out-of-line-definition-of-class-templates-destructor/), which made all macOS tests fail (zero warnings expected).
I am setting this to critical with Milestone 3.2 because all tests will fail in macOS until this is fixed.