Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues encountered by the Fujitsu compiler #2261

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Fix issues encountered by the Fujitsu compiler #2261

merged 7 commits into from
Mar 8, 2022

Conversation

hakonsbm
Copy link
Contributor

This PR fixes issues that surfaced when compiling with the Fujitsu compiler on Fugaku.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 14, 2022
@hakonsbm hakonsbm added this to PRs in progress in Kernel via automation Jan 14, 2022
@hakonsbm hakonsbm added this to To do in Installation via automation Jan 14, 2022
@hakonsbm hakonsbm added this to In progress in Automated testing via automation Jan 14, 2022
@gtrensch gtrensch moved this from To do to Review in Installation Jan 17, 2022
@clinssen clinssen requested review from heplesser and jougs March 7, 2022 09:57
heplesser
heplesser reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just got one question, see below.

cmake/CheckExtraCompilerFeatures.cmake Outdated
@@ -259,7 +259,11 @@ function( NEST_CHECK_RANDOM123 )
if ( ${COMPILE_RESULT} AND ${RUN_RESULT} EQUAL 0 )
set( HAVE_RANDOM123 ON )
else ()
message( ${RUN_OUTPUT} )
if ("${RUN_OUTPUT}" STREQUAL "")
message( "Test output is empty." )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this message? Would it not be better to call message() only if RUN_OUTPUT is not empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN_OUTPUT is empty only when the compilation of the Random123 tests failed, so I've added a message for that instead.

jougs
jougs approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Automated testing automation moved this from In progress to Reviewer approved Mar 7, 2022
Kernel automation moved this from PRs in progress to PRs approved Mar 7, 2022
@hakonsbm hakonsbm requested a review from heplesser March 8, 2022 09:50
@heplesser heplesser merged commit 4cbbd89 into nest:master Mar 8, 2022
Automated testing automation moved this from Reviewer approved to Done Mar 8, 2022
Installation automation moved this from Review to Done Mar 8, 2022
Kernel automation moved this from PRs approved to Done (PRs and issues) Mar 8, 2022
@hakonsbm hakonsbm deleted the minor_fixes branch March 8, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Installation
  
Done
Kernel
  
Done
Automated testing
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor variable initialization to avoid C++17 feature for type deduction
3 participants
@hakonsbm @heplesser @jougs