Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add version number for clang-format #2279

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Re-add version number for clang-format #2279

merged 1 commit into from
Jan 27, 2022

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Jan 27, 2022

This avoids problems when multiple versions are around and fixes #2276.

@jougs jougs added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 27, 2022
@jougs jougs added this to the NEST 3.3 milestone Jan 27, 2022
@jougs jougs self-assigned this Jan 27, 2022
@jougs jougs added this to To do in Build system and CI via automation Jan 27, 2022
@jougs jougs mentioned this pull request Jan 27, 2022
Closed
terhorstd
terhorstd approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terhorstd terhorstd merged commit 8ea4121 into nest:master Jan 27, 2022
Build system and CI automation moved this from To do to Done Jan 27, 2022
@hakonsbm hakonsbm mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees

@jougs jougs

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Milestone
NEST 3.3
Development

Successfully merging this pull request may close these issues.

Inconsistent formatting since clang-format 9 merge
3 participants
@jougs @heplesser @terhorstd