Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA clang format issue #2281

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix GHA clang format issue #2281

merged 2 commits into from
Feb 8, 2022

Conversation

hakonsbm
Copy link
Contributor

Fixes an issue with the static code checks where clang-format failed because version 9 was not installed (it is required since #2279). That led to every formatting check of C++ files failing with the following message:

./build_support/static_code_analysis.sh: line 90: clang-format-9: command not found

This PR adds clang-format-9 to system dependencies, which fixes the problem. Additionally, the static code analysis script aborts if any of the requested tools are not found.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 31, 2022
@hakonsbm hakonsbm added this to the NEST 3.3 milestone Jan 31, 2022
@hakonsbm hakonsbm added this to To do in Build system and CI via automation Jan 31, 2022
heplesser
heplesser approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinebuu stinebuu self-requested a review February 8, 2022 13:58
stinebuu
stinebuu approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinebuu stinebuu merged commit f2623eb into nest:master Feb 8, 2022
Build system and CI automation moved this from To do to Done Feb 8, 2022
@hakonsbm hakonsbm deleted the fix_gha_clang_format_issue branch February 8, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@stinebuu stinebuu stinebuu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
  
Done
Milestone
NEST 3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakonsbm @heplesser @stinebuu