Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize double and integer synapse parameters in connect_arrays() #2298

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Generalize double and integer synapse parameters in connect_arrays() #2298

merged 3 commits into from
Apr 20, 2022

Conversation

hakonsbm
Copy link
Contributor

Synapse parameters in connect_arrays() are now checked against the default values for that synapse model, and stored in a SLI Dictionary with the correct type. Fixes #2285.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 16, 2022
@hakonsbm hakonsbm added this to PRs in progress in Kernel via automation Feb 16, 2022
stinebuu
stinebuu reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I only have a tiny comment.

nestkernel/connection_manager.cpp Outdated Show resolved Hide resolved
@hakonsbm @stinebuu
Updated comment
caa7578 
Co-authored-by: Stine Brekke Vennemo <stine.vennemo@gmail.com>
stinebuu
stinebuu approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Kernel automation moved this from PRs in progress to PRs approved Feb 18, 2022
@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Apr 20, 2022
mlober
mlober approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@mlober mlober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for approving so late, I did not realize I was a reviewer until now. Everything looks good to me.

@heplesser heplesser merged commit ae35080 into nest:master Apr 20, 2022
Kernel automation moved this from PRs approved to Done (PRs and issues) Apr 20, 2022
@hakonsbm hakonsbm deleted the connect_arrays_synapse_label branch April 20, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinebuu stinebuu stinebuu approved these changes

@mlober mlober mlober approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't specify synapse label when using array indices and one-to-one connection rule
4 participants
@hakonsbm @stinebuu @mlober @heplesser