-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize double and integer synapse parameters in connect_arrays()
#2298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I only have a tiny comment.
Co-authored-by: Stine Brekke Vennemo <stine.vennemo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull request automatically marked stale! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for approving so late, I did not realize I was a reviewer until now. Everything looks good to me.
Synapse parameters in
connect_arrays()
are now checked against the default values for that synapse model, and stored in a SLIDictionary
with the correct type. Fixes #2285.