Represent singularity-safe propagators for IAF models as classes #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
…stinebuu_propagator_class
heplesser
added
S: Normal
jessica-mitchell
requested changes
Nov 10, 2022
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
|
@clinssen Ping! |
jessica-mitchell
approved these changes
Nov 28, 2022
…nebuu_propagator_class
clinssen
approved these changes
Nov 29, 2022
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
|
@clinssen I am confused by the suggestions containing images. Could you clarify what you mean? In cells creating plots I tend to be generous with semicolons to suppress text output. Strictly speaking a semicolon is only needed after the final plot command in a cell, but tracking that during development is a bit tedious. I will review your comment on the plausibility argument. |
|
@clinssen I merged the newest changes from master in the hope that all tests will pass again and beautified the notebook a bit more. |
…-simulator into stinebuu_propagator_class
Co-authored-by: Stine Brekke Vennemo <stine.vennemo@gmail.com>
…_propagator_class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up replacing #2356. The content is the same except for the last few commits, which change the class names to
IAFPropagator{Exp,Alpha}, make some changes to what is inlined and what not, and update documentation.#2294 depends on this one.