-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Represent singularity-safe propagators for IAF models as classes #2385
Conversation
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
…stinebuu_propagator_class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly had a look at the code structure and this looks good to me. Regarding the propagator implementations itself, I trust the review of @clinssen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few commetns, see in line
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@clinssen Ping! |
…nebuu_propagator_class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with only a few minor comments. Cheers!
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
doc/htmldoc/neurons/model_details/IAF_Integration_Singularity.ipynb
Outdated
Show resolved
Hide resolved
@clinssen I am confused by the suggestions containing images. Could you clarify what you mean? In cells creating plots I tend to be generous with semicolons to suppress text output. Strictly speaking a semicolon is only needed after the final plot command in a cell, but tracking that during development is a bit tedious. I will review your comment on the plausibility argument. |
@clinssen I merged the newest changes from master in the hope that all tests will pass again and beautified the notebook a bit more. |
…-simulator into stinebuu_propagator_class
Co-authored-by: Stine Brekke Vennemo <stine.vennemo@gmail.com>
…_propagator_class
This PR is a follow-up replacing #2356. The content is the same except for the last few commits, which change the class names to
IAFPropagator{Exp,Alpha}
, make some changes to what is inlined and what not, and update documentation.#2294 depends on this one.