Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PIL dependency in Sudoku Example #2467

Merged
merged 13 commits into from
Oct 26, 2022

Conversation

krachbumm3nte
Copy link
Contributor

As discussed in #2441, I have updated the visualization backend for the Sudoku example to rely fully on matplotlib and imageio.

Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In addition to my suggestions below, the sudoku_solver.py script also needs to be updated to work with the changed function arguments in helpers.py.

pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
krachbumm3nte and others added 2 commits October 21, 2022 14:52
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
@jougs jougs requested a review from hakonsbm October 24, 2022 13:29
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I have a few more suggestions.

pynest/examples/sudoku/helpers.py Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/plot_progress.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/sudoku_solver.py Outdated Show resolved Hide resolved
krachbumm3nte and others added 2 commits October 25, 2022 16:14
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@heplesser
Copy link
Contributor

heplesser commented Oct 26, 2022

@krachbumm3nte Could you pull master into this branch? Then the macOS test should pass (see #2515).

Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR. Other than a couple of formatting issues, I'm fine.

pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Show resolved Hide resolved
pynest/examples/sudoku/helpers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reaction. I think this looks much better now.

@heplesser
Copy link
Contributor

@krachbumm3nte Thanks a lot, I will merge this now. I noticed that many docstrings begin with lowercase letters, e.g.,

def get_puzzle(puzzle_index):
     """returns one of 8 Sudoku configuration to be solved.

Our style is to begin docstrings with capital letters, e.g., here """Returns one ...". Could you at some point create another PR fixing this?

@heplesser heplesser merged commit 4357c8d into nest:master Oct 26, 2022
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants