Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the Python imaging library PIL with matplotlib in the Sudoku example #2441

Closed
gtrensch opened this issue Aug 1, 2022 · 4 comments
Closed

Replace the Python imaging library PIL with matplotlib in the Sudoku example #2441

gtrensch opened this issue Aug 1, 2022 · 4 comments
Assignees
@krachbumm3nte
Labels
S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation

Comments

@gtrensch
Copy link
Contributor

gtrensch commented Aug 1, 2022

Problem Description

The Sudoku example introduced with #2384 makes use of the Python imaging library PIL. Since we want to keep Python dependencies as low as possible, we would like to replace PLI with a matplotlib solution. An example for drawing a Sudoku field using matplotlib can be found here.
@gtrensch gtrensch added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority labels Aug 1, 2022
@jessica-mitchell
Copy link
Contributor

@krachbumm3nte Can you take a look at this when you get a chance?

@krachbumm3nte
Copy link
Contributor

Yes, I can take care of it. As far as I can tell I'm not a Collaborator yet, so I can't self-assign. Could you do that for me @jessica-mitchell ?

@krachbumm3nte krachbumm3nte mentioned this issue Sep 11, 2022
Merged
krachbumm3nte added a commit to krachbumm3nte/nest-simulator that referenced this issue Sep 12, 2022
@krachbumm3nte
Change gif generation script from PIL to matplotlib as required by ne…
95ce901 
…st#2441
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Nov 7, 2022
@jessica-mitchell
Copy link
Contributor

Closing issue as it is resolved with PR #2467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krachbumm3nte krachbumm3nte

Labels
S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Documentation
Status: Done
Models
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessica-mitchell @gtrensch @krachbumm3nte